Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add security section for Sapphire/OPL #513

Merged
merged 2 commits into from
Nov 14, 2023
Merged

Add security section for Sapphire/OPL #513

merged 2 commits into from
Nov 14, 2023

Conversation

aefhm
Copy link
Contributor

@aefhm aefhm commented Aug 29, 2023 •
edited by matevz
Loading

Why

Relates to #509

Preview

@aefhm aefhm self-assigned this Aug 29, 2023
@kostko
Copy link
Member

kostko commented Aug 29, 2023

Task linked: CU-8692kbhwx Storage I/O Patterns

@netlify
Copy link

netlify bot commented Aug 29, 2023 •
edited
Loading

✅ Deploy Preview for trusting-archimedes-14c863 ready!

Name Link
🔨 Latest commit 92586e7
🔍 Latest deploy log https://app.netlify.com/sites/trusting-archimedes-14c863/deploys/6553ab71961a9700088ab6fe
😎 Deploy Preview https://deploy-preview-513--trusting-archimedes-14c863.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@aefhm aefhm added documentation Improvements or additions to documentation enhancement New feature or request examples Fixes in the examples code labels Aug 29, 2023
@aefhm aefhm marked this pull request as ready for review September 4, 2023 15:39
@aefhm aefhm requested a review from matevz September 5, 2023 03:46
matevz
matevz requested changes Sep 5, 2023
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass.

docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
sidebarDapp.js Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the CU-8692kbhwx_Storage-IO-Patterns_Xi-Zhang branch 2 times, most recently from 5d3cc98 to b1f8e8c Compare September 7, 2023 03:57
@aefhm aefhm force-pushed the CU-8692kbhwx_Storage-IO-Patterns_Xi-Zhang branch from b1f8e8c to a4271b1 Compare September 26, 2023 16:23
@aefhm aefhm requested a review from matevz September 26, 2023 16:24
@aefhm aefhm force-pushed the CU-8692kbhwx_Storage-IO-Patterns_Xi-Zhang branch from a4271b1 to c856ffe Compare October 6, 2023 20:39
@aefhm aefhm force-pushed the CU-8692kbhwx_Storage-IO-Patterns_Xi-Zhang branch 3 times, most recently from d37d105 to 2c9ea44 Compare November 8, 2023 23:42
matevz
matevz approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@matevz matevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits. Otherwise, LGTM!

docs/dapp/sapphire/guide.mdx Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Show resolved Hide resolved
docs/dapp/sapphire/security.md Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
docs/dapp/sapphire/security.md Outdated Show resolved Hide resolved
@aefhm aefhm force-pushed the CU-8692kbhwx_Storage-IO-Patterns_Xi-Zhang branch from d6ff13c to af5c5da Compare November 14, 2023 17:14
@aefhm aefhm force-pushed the CU-8692kbhwx_Storage-IO-Patterns_Xi-Zhang branch from af5c5da to 92586e7 Compare November 14, 2023 17:16
@aefhm aefhm enabled auto-merge November 14, 2023 17:20
@aefhm aefhm changed the title Start security section for Sapphire/OPL Add security section for Sapphire/OPL Nov 14, 2023
@aefhm aefhm merged commit 0eeadfd into main Nov 14, 2023
5 checks passed
@aefhm aefhm deleted the CU-8692kbhwx_Storage-IO-Patterns_Xi-Zhang branch November 14, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matevz matevz matevz approved these changes

Assignees

@aefhm aefhm

Labels
documentation Improvements or additions to documentation enhancement New feature or request examples Fixes in the examples code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aefhm @kostko @matevz